Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[simple] add duckduckgo to load_tools.py #3376

Merged
merged 6 commits into from
Apr 25, 2023

Conversation

skcoirz
Copy link
Contributor

@skcoirz skcoirz commented Apr 23, 2023

  • duckduckgo was introduced in Harrison/ddg #3206, but it’s not enabled in load_tools.py yet.
  • this PR simply enables it in load_tools.py with a straightforward agent call (as described in get_started doc) to verify the functionality.
  • duckduckgo integration test passed.

TODO:

  • not seeing an agent specific integration. Since I’m still ramping up here, will add it in a following PR.
  • it looks like DuckDuckGo is using a different naming convention with postfix “-Tool” vs “-Run” comparing with others. The work is straightforward and it is a great way to explore the codebase, so I decided to take the chance to deeply read the codebase and then make the straightforward change in the next PR. :)

This is my first PR. Please let me know if there is anything I can improve. Thank you so much!

Agent Call with DuckDuckGo instead. Screenshot 2023-04-22 at 8 44 18 PM

@skcoirz
Copy link
Contributor Author

skcoirz commented Apr 24, 2023

trunk has a lint error. fixed it in the latest commit.

TODO: will add missing annotation to the rest variables. It will touch a lot of them. So to keep the commit focus and clear, I’ll do them in another PR.

@skcoirz
Copy link
Contributor Author

skcoirz commented Apr 24, 2023

thank you for accepting my PR, @vowelparrot ! I found there is a lint error in the latest trunk. Just fixed it in one of the commit here. Please take a look when you have time. As commented above, I’ll add annotation to the rest variables in the file to keep them consistent. Thanks!

@vowelparrot vowelparrot changed the base branch from master to vwp/ddg April 25, 2023 17:08
@vowelparrot vowelparrot merged commit 0ca9528 into langchain-ai:vwp/ddg Apr 25, 2023
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants