Add _type for all parsers #4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Replicating the PR: #3332 |
|
@hwchase17, can you help take a look at this? Thank you :) |
dev2049
reviewed
May 10, 2023
Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
sunishsheth2009
force-pushed
the
parser__type
branch
2 times, most recently
from
1c5f1b9
to
a7c6043
Compare
dev2049
reviewed
May 10, 2023
| try: | ||
| # Most parsers just return a string. MagicMock lets | ||
| # the parsers that wrap another parsers slide by | ||
| cls._type.fget(MagicMock()) # type: ignore |
There was a problem hiding this comment.
not sure i understand, why is this needed?
There was a problem hiding this comment.
I agree, its not needed here. There are no parsers that wrap another parser. Removed that code. :)
Thank you
dev2049
reviewed
May 10, 2023
Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
sunishsheth2009
force-pushed
the
parser__type
branch
from
a7c6043
to
8584473
Compare
jpzhangvincent
pushed a commit
to jpzhangvincent/langchain
that referenced
this pull request
May 12, 2023
Used for serialization. Also add test that recurses through our subclasses to check they have them implemented Would fix langchain-ai#3217 Blocking: mlflow/mlflow#8297 --------- Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com> Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
EandrewJones
pushed a commit
to Oogway-Technologies/langchain
that referenced
this pull request
May 12, 2023
Used for serialization. Also add test that recurses through our subclasses to check they have them implemented Would fix langchain-ai#3217 Blocking: mlflow/mlflow#8297 --------- Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com> Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used for serialization. Also add test that recurses through
our subclasses to check they have them implemented
Would fix #3217
Blocking: mlflow/mlflow#8297