Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding agent support to LangChain flavor #8297

Merged
merged 5 commits into from May 16, 2023
Merged

Adding agent support to LangChain flavor #8297

merged 5 commits into from May 16, 2023

Conversation

sunishsheth2009
Copy link
Collaborator

What changes are proposed in this pull request?

Adding agent support to LangChain flavor

How is this patch tested?

  • Added test
  • Ran the agent example in a notebook

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Adding agent support to LangChain flavor

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@sunishsheth2009 sunishsheth2009 force-pushed the sunish-add-langchain-agent-support branch from 8f8bbc6 to 76c1ea5 Compare April 21, 2023 16:44
@mlflow-automation
Copy link
Collaborator

mlflow-automation commented Apr 21, 2023 •
edited

Documentation preview for ae3a93b will be available here when this CircleCI job completes successfully.

More info

@github-actions github-actions bot added area/tracking Tracking service, tracking client APIs, autologging rn/feature Mention under Features in Changelogs. labels Apr 21, 2023
@sunishsheth2009 sunishsheth2009 force-pushed the sunish-add-langchain-agent-support branch from 76c1ea5 to 29f16fb Compare April 21, 2023 17:25
@mlflow mlflow deleted a comment from github-actions bot Apr 21, 2023
BenWilson2
BenWilson2 reviewed Apr 21, 2023
View reviewed changes
mlflow/langchain/__init__.py Outdated Show resolved Hide resolved
mlflow/langchain/__init__.py Outdated Show resolved Hide resolved
mlflow/langchain/__init__.py Outdated Show resolved Hide resolved
mlflow/langchain/__init__.py Outdated Show resolved Hide resolved
mlflow/langchain/__init__.py Outdated Show resolved Hide resolved
mlflow/langchain/__init__.py Outdated Show resolved Hide resolved
mlflow/langchain/__init__.py Outdated Show resolved Hide resolved
mlflow/langchain/__init__.py Outdated Show resolved Hide resolved
mlflow/ml-package-versions.yml Show resolved Hide resolved
dbczumar
dbczumar reviewed Apr 21, 2023
View reviewed changes
examples/langchain/simple_agent.py
from langchain.llms import OpenAI

assert "OPENAI_API_KEY" in os.environ, "Please set the OPENAI_API_KEY environment variable."
assert "SERPAPI_API_KEY" in os.environ, "Please set the SERPAPI_API_KEY environment variable."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @vladimirk-db @sueann This example can't be used with Databricks model serving because SERPAPI isn't supported. Something for us to think about in the future :)

BenWilson2
BenWilson2 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@BenWilson2 BenWilson2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great stuff @sunishsheth2009 ! Is there going to be a followup PR to update the flavor description capabilities in models.rst?

@dbczumar
Copy link
Collaborator

LGTM! Great stuff @sunishsheth2009 ! Is there going to be a followup PR to update the flavor description capabilities in models.rst?

+1 @sunishsheth2009 we should make sure to update docs and API docstrings for this :)

@sunishsheth2009 sunishsheth2009 force-pushed the sunish-add-langchain-agent-support branch from 16272ec to c23804d Compare April 21, 2023 21:08
harupy
harupy reviewed Apr 24, 2023
View reviewed changes
docs/source/models.rst Outdated Show resolved Hide resolved
@sunishsheth2009 sunishsheth2009 force-pushed the sunish-add-langchain-agent-support branch 3 times, most recently from f6c5762 to 8658b64 Compare April 24, 2023 18:12
@sunishsheth2009 sunishsheth2009 mentioned this pull request May 5, 2023
Merged
dev2049 added a commit to langchain-ai/langchain that referenced this pull request May 11, 2023
@sunishsheth2009 @dev2049
Add _type for all parsers (#4189)
812e5f4 
Used for serialization. Also add test that recurses through
our subclasses to check they have them implemented

Would fix #3217
Blocking: mlflow/mlflow#8297

---------

Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
@sunishsheth2009
Adding agent support to LangChain flavor
78c69a7 
Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
@sunishsheth2009
Resolving comments
8eec7bc 
Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
@sunishsheth2009 sunishsheth2009 force-pushed the sunish-add-langchain-agent-support branch from 8658b64 to 6ecb545 Compare May 11, 2023 16:13
@sunishsheth2009
Update version to check langchain tests
1cf93a1 
Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
@sunishsheth2009 sunishsheth2009 force-pushed the sunish-add-langchain-agent-support branch 2 times, most recently from 88012c6 to 541c4fe Compare May 11, 2023 18:01
jpzhangvincent pushed a commit to jpzhangvincent/langchain that referenced this pull request May 12, 2023
@sunishsheth2009 @dev2049 @jpzhangvincent
Add _type for all parsers (langchain-ai#4189)
b935bad 
Used for serialization. Also add test that recurses through
our subclasses to check they have them implemented

Would fix langchain-ai#3217
Blocking: mlflow/mlflow#8297

---------

Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
EandrewJones pushed a commit to Oogway-Technologies/langchain that referenced this pull request May 12, 2023
@sunishsheth2009 @dev2049 @EandrewJones
Add _type for all parsers (langchain-ai#4189)
b53c8f5 
Used for serialization. Also add test that recurses through
our subclasses to check they have them implemented

Would fix langchain-ai#3217
Blocking: mlflow/mlflow#8297

---------

Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
@sunishsheth2009
Checking for serialization bug
afb9a37 
Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
@sunishsheth2009 sunishsheth2009 force-pushed the sunish-add-langchain-agent-support branch from 541c4fe to afb9a37 Compare May 15, 2023 18:11
@sunishsheth2009
Fixing tests
ae3a93b 
Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
@sunishsheth2009 sunishsheth2009 force-pushed the sunish-add-langchain-agent-support branch from 6e965a4 to ae3a93b Compare May 15, 2023 21:31
harupy
harupy approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sunishsheth2009 sunishsheth2009 merged commit 76c1a24 into master May 16, 2023
28 of 29 checks passed
@sunishsheth2009 sunishsheth2009 deleted the sunish-add-langchain-agent-support branch May 16, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbczumar dbczumar dbczumar left review comments

@harupy harupy harupy approved these changes

@BenWilson2 BenWilson2 BenWilson2 approved these changes

@jinzhang21 jinzhang21 jinzhang21 approved these changes

Assignees
No one assigned
Labels
area/tracking Tracking service, tracking client APIs, autologging rn/feature Mention under Features in Changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sunishsheth2009 @mlflow-automation @dbczumar @harupy @BenWilson2 @jinzhang21