Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interfaces for async embeddings, implement async openai #6563

Merged
merged 3 commits into from
Jun 22, 2023
Merged

feat: interfaces for async embeddings, implement async openai #6563

merged 3 commits into from
Jun 22, 2023

Conversation

BrendanGraham14
Copy link
Contributor

Since it seems like #6111 will be blocked for a bit, I've forked @tyree731's fork and implemented the requested changes.

This change adds support to the base Embeddings class for two methods, aembed_query and aembed_documents, those two methods supporting async equivalents of embed_query and
embed_documents respectively. This ever so slightly rounds out async support within langchain, with an initial implementation of this functionality being implemented for openai.

Implements #6109

tyree731 and others added 3 commits June 13, 2023 16:15
This change adds support to the base `Embeddings` class for two
methods, `aembed_query` and `aembed_documents`, those two methods
supporting async equivalents of `embed_query` and
`embed_documents` respectively. This ever so slightly rounds out
async support within langchain, with an initial implementation
of this functionality being implemented for openai.

Implements #6109
@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ❌ Failed (Inspect) Jun 21, 2023 8:41pm

@vercel vercel bot temporarily deployed to Preview June 21, 2023 20:41 Inactive
@dev2049 dev2049 requested a review from agola11 June 22, 2023 02:19
Copy link
Collaborator

@agola11 agola11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@BrendanGraham14
Copy link
Contributor Author

@agola11 Is there something I need to do to resolve the vercel failure?

@hwchase17 hwchase17 merged commit d718f3b into langchain-ai:master Jun 22, 2023
13 of 14 checks passed
tconkling added a commit to tconkling/langchain that referenced this pull request Jun 22, 2023
* master:
  MD header text splitter returns Documents (langchain-ai#6571)
  Fix callback forwarding in async plan method for OpenAI function agent (langchain-ai#6584)
  bump 209 (langchain-ai#6593)
  Clarifai integration (langchain-ai#5954)
  Add missing word in comment (langchain-ai#6587)
  Add AzureML endpoint LLM wrapper (langchain-ai#6580)
  Add OpenLLM wrapper(langchain-ai#6578)
  feat: interfaces for async embeddings, implement async openai (langchain-ai#6563)
  Upgrade the version of AwaDB and add some new interfaces (langchain-ai#6565)
  add motherduck docs (langchain-ai#6572)
  Detailed using the Twilio tool to send messages with 3rd party apps incl. WhatsApp (langchain-ai#6562)
  Change Data Loader Namespace (langchain-ai#6568)
  Remove duplicate databricks entries in ecosystem integrations (langchain-ai#6569)
  Fix whatsappchatloader - enable parsing new datetime format on WhatsApp chat (langchain-ai#6555)
  Wait for all futures (langchain-ai#6554)
  feat: faiss filter from list (langchain-ai#6537)
  update pr tmpl (langchain-ai#6552)
  Remove unintended double negation in docstring (langchain-ai#6541)
  Minor Grammar Fixes in Docs and Comments (langchain-ai#6536)
@BrendanGraham14 BrendanGraham14 deleted the async-embedding-support branch June 22, 2023 22:19
This was referenced Jun 25, 2023
kacperlukawski pushed a commit to kacperlukawski/langchain that referenced this pull request Jun 29, 2023
…ain-ai#6563)

Since it seems like langchain-ai#6111 will be blocked for a bit, I've forked
@tyree731's fork and implemented the requested changes.

This change adds support to the base Embeddings class for two methods,
aembed_query and aembed_documents, those two methods supporting async
equivalents of embed_query and
embed_documents respectively. This ever so slightly rounds out async
support within langchain, with an initial implementation of this
functionality being implemented for openai.

Implements langchain-ai#6109

---------

Co-authored-by: Stephen Tyree <tyree731@gmail.com>
aerrober pushed a commit to aerrober/langchain-fork that referenced this pull request Jul 24, 2023
…ain-ai#6563)

Since it seems like langchain-ai#6111 will be blocked for a bit, I've forked
@tyree731's fork and implemented the requested changes.

This change adds support to the base Embeddings class for two methods,
aembed_query and aembed_documents, those two methods supporting async
equivalents of embed_query and
embed_documents respectively. This ever so slightly rounds out async
support within langchain, with an initial implementation of this
functionality being implemented for openai.

Implements langchain-ai#6109

---------

Co-authored-by: Stephen Tyree <tyree731@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants