MD header text splitter returns Documents #6571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
rlancemartin
force-pushed
the
rlm/md_splitter_return_docs
branch
7 times, most recently
from
81db987
to
0e10d6a
Compare
There was a problem hiding this comment.
PR Analysis
- 🎯 Main theme: The PR modifies the MarkdownHeaderTextSplitter to return Documents instead of dictionaries, and updates the relevant tests and documentation.
- 🔍 Description and title: yes
- 📌 Type of PR: Enhancement
- 🧪 Relevant tests added: yes
⚠️ Unrelated changes: no- ✨ Minimal and focused: yes
PR Feedback
- 💡 Suggestions: The changes look good and are consistent with the main theme of the PR.
- 🌱 Minor suggestions: Consider updating the PR description to mention the updates to the tests and documentation.
- 🤖 Code Suggestions:
rlancemartin
force-pushed
the
rlm/md_splitter_return_docs
branch
2 times, most recently
from
7b89304
to
8fe80b9
Compare
rlancemartin
force-pushed
the
rlm/md_splitter_return_docs
branch
from
8fe80b9
to
3d38733
Compare
tconkling
added a commit
to tconkling/langchain
that referenced
this pull request
Jun 22, 2023
* master: MD header text splitter returns Documents (langchain-ai#6571) Fix callback forwarding in async plan method for OpenAI function agent (langchain-ai#6584) bump 209 (langchain-ai#6593) Clarifai integration (langchain-ai#5954) Add missing word in comment (langchain-ai#6587) Add AzureML endpoint LLM wrapper (langchain-ai#6580) Add OpenLLM wrapper(langchain-ai#6578) feat: interfaces for async embeddings, implement async openai (langchain-ai#6563) Upgrade the version of AwaDB and add some new interfaces (langchain-ai#6565) add motherduck docs (langchain-ai#6572) Detailed using the Twilio tool to send messages with 3rd party apps incl. WhatsApp (langchain-ai#6562) Change Data Loader Namespace (langchain-ai#6568) Remove duplicate databricks entries in ecosystem integrations (langchain-ai#6569) Fix whatsappchatloader - enable parsing new datetime format on WhatsApp chat (langchain-ai#6555) Wait for all futures (langchain-ai#6554) feat: faiss filter from list (langchain-ai#6537) update pr tmpl (langchain-ai#6552) Remove unintended double negation in docstring (langchain-ai#6541) Minor Grammar Fixes in Docs and Comments (langchain-ai#6536)
kacperlukawski
pushed a commit
to kacperlukawski/langchain
that referenced
this pull request
Jun 29, 2023
Return `Documents` from MD header text splitter to simplify UX. Updates the test as well as example notebooks.
aerrober
pushed a commit
to aerrober/langchain-fork
that referenced
this pull request
Jul 24, 2023
Return `Documents` from MD header text splitter to simplify UX. Updates the test as well as example notebooks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return
Documentsfrom MD header text splitter to simplify UX.Updates the test as well as example notebooks.