Gpapp/chromadb #7891
Merged
Gpapp/chromadb #7891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: vector store
|
cc @jeffchuber |
|
@baskaryan we are good for this ... we would like to upgrade the default version for new users as in https://github.com/hwchase17/langchain/pull/7749/files however. how do you think we should merge these? |
|
@baskaryan our preference would be to migrate users to the new system however. strong opinion loosely held. all new updates will be to ^0.4.0 |
down to land this then #7749, that way we get both? new users get latest, old users don't see things break |
baskaryan
added
lgtm
baskaryan
reviewed
Jul 18, 2023
langchain/vectorstores/chroma.py
Outdated
|
|
||
| # Maintain backwards compatibility with chromadb < 0.4.0 | ||
| major, minor, _ = chromadb.__version__.split(".") | ||
| if int(major) >= 0 and int(minor) < 4: |
2 tasks
aerrober
pushed a commit
to aerrober/langchain-fork
that referenced
this pull request
Jul 24, 2023
- Description: version check to make sure chromadb >=0.4.0 does not throw an error, and uses the default sqlite persistence engine when the directory is set, - Issue: the issue langchain-ai#7887 For attention of - DataLoaders / VectorStores / Retrievers: @rlancemartin, @eyurtsev --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For attention of