upgrade chroma to 0.4.0 #7749
Merged
upgrade chroma to 0.4.0 #7749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: vector store
|
This requires more work - first resolving the fastapi version issue. |
HammadB
pushed a commit
to chroma-core/chroma
that referenced
this pull request
Jul 17, 2023
bump to a higher range of fastapi - more up to date is better - conflict with langchain-ai/langchain#7749, specific failing tests https://github.com/hwchase17/langchain/actions/runs/5560775388/jobs/10157995239?pr=7749
baskaryan
reviewed
Jul 18, 2023
langchain/vectorstores/chroma.py
Outdated
| @@ -95,7 +95,7 @@ def __init__( | |||
| _client_settings = client_settings | |||
| elif persist_directory: | |||
| _client_settings = chromadb.config.Settings( | |||
| chroma_db_impl="duckdb+parquet", | |||
| is_persistent=True, | |||
There was a problem hiding this comment.
is update backwards compatible with old config settings? ie if someone was passing in
_client_settings = chromadb.config.Settings(
chroma_db_impl="duckdb+parquet",
persist_directory=persist_directory,
)directly before, would behavior they're seeing change?
There was a problem hiding this comment.
they will see this error
You are using a deprecated configuration of Chroma. Please pip install chroma-migrate and run chroma-migrate to upgrade your configuration. See https://docs.trychroma.com/migration for more information or join our discord at https://discord.gg/8g5FESbj for help!
more here https://docs.trychroma.com/migration
Merged
baskaryan
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** This should land Monday the 17th **
Chroma is upgrading from
0.3.29to0.4.0.0.4.0is easier to build, more durable, faster, smaller, and more extensible. This comes with a few changes:A simplified and improved client setup. Instead of having to remember weird settings, users can just do
EphemeralClient,PersistentClientorHttpClient(the underlying directClientimplementation is also still accessible)We migrated data stores away from
duckdbandclickhouse. This changes the api for thePersistentClientthat used to referencechroma_db_impl="duckdb+parquet". Now we simply setis_persistent=true.is_persistentis set for you totrueif you usePersistentClient.Because we migrated away from
duckdbandclickhouse- this also means that users need to migrate their data into the new layout and schema. Chroma is committed to providing extension notification and tooling around any schema and data migrations (for example - this PR!).After upgrading to
0.4.0- if users try to access their data that was stored in the previous regime, the system will throw anExceptionand instruct them how to use the migration assistant to migrate their data. The migration assitant is a pip installable CLI:pip install chroma_migrate. And is runnable by callingchroma_migrate-- TODO ADD here is a short video demonstrating how it works.
Please reference the readme at chroma-core/chroma-migrate to see a full write-up of our philosophy on migrations as well as more details about this particular migration.
Please direct any users facing issues upgrading to our Discord channel called #get-help. We have also created a email listserv to notify developers directly in the future about breaking changes.
TODO
duckdb+parquetstrings to the new format0.4.0after0.4.0is released.fastapito the chroma branch - as is in-progress here test this range chroma-core/chroma#807