Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Pydantic v2 #8330

Closed
wants to merge 3 commits into from
Closed

Upgrade to Pydantic v2 #8330

wants to merge 3 commits into from

Conversation

srhinos
Copy link

@srhinos srhinos commented Jul 27, 2023

This PR should encompass (most of) the changes needed to support Pydantic v2

Relevant Issue: #6841

Dependency wise, had to bump Pydantic (ofc) and autodoc-pydantic which has a yanked 2.0.0 pypi deploy which is being used as a Release Candidate for pydantic v2 support.

Currently, the following deps are preventing poetry from resolving a lock file:

@baskaryan

Opened as a draft because until poetry resolves the lock file and downstream packages get resolved, it shouldn't be merged.

Also since PR guidelines suggests, twitter handle is SexualRhino_

@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 27, 2023 0:38am

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Jul 27, 2023
@srhinos
Copy link
Author

srhinos commented Aug 1, 2023 via email

@quitrk
Copy link

quitrk commented Aug 10, 2023

Spacy doesn’t look like it’ll be getting a fix anytime soon so pending langchain completely removing the dependency, it’ll be blocked on that getting fixed as well :(

Looks like they actually merged Pydantic v2 support and it's available starting with v3.6.1

@arpagon arpagon mentioned this pull request Aug 15, 2023
@baskaryan
Copy link
Collaborator

v2 should be supported as of langchain==0.0.267, we'd love to hear if that's working for folks. See #9337 for more detailed info.

@eyurtsev
Copy link
Collaborator

@srhinos thank you for the PR! Handled via v1/v2 compatibility for now

@eyurtsev eyurtsev closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants