Upgrade to Pydantic v2 #8330
Closed
Upgrade to Pydantic v2 #8330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:improvement
7 tasks
|
This is really only blocked by dependencies so until those get resolved (they’re all linked in the description), not much I can do to finalize this PR :(
If you wanna go tackle the chromadb issue or the steamship issue, both have maintainers interested in getting fixes in. Spacy doesn’t look like it’ll be getting a fix anytime soon so pending langchain completely removing the dependency, it’ll be blocked on that getting fixed as well :(
There’s a half solution that could be done to unpin the version and implement a try, catch over every pydantic import to try for the v1 import so v2 can at least be resolved by poetry but it’ll mean all dependencies blocking pure v2 will throw errors.
…
On Aug 1, 2023 at 10:52 AM, <Altay Sansal ***@***.***)> wrote:
any luck pushing this forward? if you can give some history/roadmap/todo I can see if there is anything I can help with :)
—
Reply to this email directly, view it on GitHub (#8330 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/ABR2SQIEIUISWCA2PS3HBBLXTEJZPANCNFSM6AAAAAA2ZKLVKU).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Looks like they actually merged Pydantic v2 support and it's available starting with v3.6.1 |
|
v2 should be supported as of langchain==0.0.267, we'd love to hear if that's working for folks. See #9337 for more detailed info. |
|
@srhinos thank you for the PR! Handled via v1/v2 compatibility for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should encompass (most of) the changes needed to support Pydantic v2
Relevant Issue: #6841
Dependency wise, had to bump Pydantic (ofc) and
autodoc-pydanticwhich has a yanked 2.0.0 pypi deploy which is being used as a Release Candidate for pydantic v2 support.Currently, the following deps are preventing poetry from resolving a lock file:
@baskaryan
Opened as a draft because until poetry resolves the lock file and downstream packages get resolved, it shouldn't be merged.
Also since PR guidelines suggests, twitter handle is SexualRhino_