Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support future pydantic v2 #12611

Closed
achapkowski opened this issue May 8, 2023 · 8 comments · Fixed by #12888
Closed

support future pydantic v2 #12611

achapkowski opened this issue May 8, 2023 · 8 comments · Fixed by #12888
Labels
enhancement Feature requests and improvements third-party Third-party packages and services

Comments

@achapkowski
Copy link

Spacy uses an older version of pydantic, please lighten the pinning to support 1.10.x and the forthcoming version 2.0.0
@adrianeboyd
Copy link
Contributor

spacy has supported pydantic v1.10.x since v3.4.2. We'll have to test carefully in order to extend support to v2.0.0.

@adrianeboyd adrianeboyd added the third-party Third-party packages and services label May 8, 2023
@adrianeboyd adrianeboyd linked a pull request May 15, 2023 that will close this issue
build: bump typer version to accept >=0.3<0.10 #12631
Merged
3 tasks
@adrianeboyd adrianeboyd removed a link to a pull request May 15, 2023
build: bump typer version to accept >=0.3<0.10 #12631
Merged
3 tasks
@adrianeboyd adrianeboyd added the enhancement Feature requests and improvements label May 19, 2023
@adrianeboyd adrianeboyd changed the title support pydantic 1.10.x+ support future pydantic v2 May 19, 2023
@lsmith77
Copy link

any update here?

@dhimmel
Copy link

dhimmel commented Jul 10, 2023

Noting that pydantic 2 was released on 2023-06-30, such that you will likely soon have many users interested in this issue 😄

@adrianeboyd
Copy link
Contributor

We have work in progress for pydantic v2 support starting with confection: explosion/confection#31

@alita-moore
Copy link

+1

@isabelizimm isabelizimm mentioned this issue Jul 25, 2023
Merged
@shadeMe shadeMe mentioned this issue Jul 27, 2023
Closed
@srhinos
Copy link

srhinos commented Jul 27, 2023

+1

@srhinos srhinos mentioned this issue Jul 27, 2023
Closed
@dhimmel
Copy link

dhimmel commented Aug 1, 2023

I'm not affiliated with this project but as general GitHub etiquette, it can be preferable to use an emoji reaction like 👍🏻 on the initial comment rather than reply a comment with solely "+1", since that dilutes the technical conversation and causes extra notifications. Of course, I agree with the +1.

Harmon758 added a commit to Harmon758/Harmonbot that referenced this issue Aug 1, 2023
@Harmon758
[Units] Use NLP to determine subject in trivia clue text
95d893f 
[Tests] Add nominal subject check to trivia clue text subject redundancy test

Revert pydantic to v1.10
explosion/spaCy#12611
@adrianeboyd adrianeboyd linked a pull request Aug 7, 2023 that will close this issue
Allow pydantic v2 using transitional v1 support #12888
Merged
3 tasks
Harmon758 added a commit to Harmon758/Harmonbot that referenced this issue Aug 9, 2023
@Harmon758
Update pydantic back to v2.1.1
4f7b193 
Now that spaCy (and its dependencies, confection and thinc) support pydantic v2
explosion/confection#38
explosion/thinc#891
explosion/spaCy#12611
explosion/spaCy#12888
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Feature requests and improvements third-party Third-party packages and services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow pydantic v2 using transitional v1 support adrianeboyd/spaCy
6 participants
@lsmith77 @dhimmel @achapkowski @adrianeboyd @srhinos @alita-moore