Add new parameter forced_decoder_ids to OpenAIWhisperParserLocal + small bug fix #8793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng tasks (translate/transcribe)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
Ɑ: doc loader
hwchase17
reviewed
Aug 6, 2023
| @@ -136,10 +156,19 @@ def __init__(self, device: str = "0", lang_model: Optional[str] = None): | |||
| # load model for inference | |||
| self.pipe = pipeline( | |||
| "automatic-speech-recognition", | |||
| model="openai/whisper-medium", | |||
| model=self.lang_model, # fix to use model name that was evaluated earlier | |||
There was a problem hiding this comment.
i would remove this comment, it loses meaning outside of this pr
hwchase17
reviewed
Aug 6, 2023
| chunk_length_s=30, | ||
| device=self.device, | ||
| ) | ||
| try: | ||
| if forced_decoder_ids is not None: |
There was a problem hiding this comment.
nit: i feel like its slightly nicer to do:
if ...:
try:
...
except:
...
dont care super strongly tho
hwchase17
added
the
lgtm
|
Minor fix - shortened 1 line due to lint failed check. Will look into why local lint didn't displayed it for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processor = WhisperProcessor.from_pretrained("openai/whisper-medium")
forced_decoder_ids = processor.get_decoder_prompt_ids(language="french", task="transcribe")
#forced_decoder_ids = processor.get_decoder_prompt_ids(language="french", task="translate")
loader = GenericLoader(YoutubeAudioLoader(urls, save_dir), OpenAIWhisperParserLocal(lang_model="openai/whisper-medium",forced_decoder_ids=forced_decoder_ids))
Please make sure you're PR is passing linting and testing before submitting. Run
make format,make lintandmake testto check this locally.See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md
-->