Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify a custom loader for GcsFileLoader #8868

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

lkuligin
Copy link
Collaborator

@lkuligin lkuligin commented Aug 7, 2023

@vercel
Copy link

vercel bot commented Aug 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 1:41pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain-deprecated ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2023 1:41pm

@dosubot dosubot bot added Ɑ: doc loader Related to document loader module (not documentation) 🤖:improvement Medium size change to existing code to handle new use-cases labels Aug 7, 2023
@eyurtsev
Copy link
Collaborator

eyurtsev commented Aug 8, 2023

@lkuligin this works and happy to merge.

Going forward we are trying to transition to using blob loaders and blob parsers for working with documents to help decouple content fetching from content parsing.

Here are examples of PDF Blob parsers:
https://api.python.langchain.com/en/latest/_modules/langchain/document_loaders/parsers/pdf.html#PDFMinerParser

Let me know if you'd be interested in working on this functionality!

@eyurtsev eyurtsev added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 8, 2023
@eyurtsev eyurtsev merged commit b52a378 into langchain-ai:master Aug 8, 2023
24 checks passed
@lkuligin
Copy link
Collaborator Author

@eyurtsev yes, I'm happy to migrate GCSFileLoader to BlobLoader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: doc loader Related to document loader module (not documentation) 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants