[test-exports-esbuild] Add missing entrypoints #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syncing entrypoints with `esm` modules since esbuild/esm should have the same imports. This should give us the expected CI test coverage in `esbuild`. Compare to `esm`: https://github.com/hwchase17/langchainjs/blob/main/test-exports-esm/src/entrypoints.js Test plan: - CI tests
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
These should be auto-generated by script - CC @nfcampos? |
This upstream fix adds `test-exports-esbuild` to `create-entrypoints.js` so that when `yarn build` is run, we'll automatically get the updated entrypoints in `test-exports-esbuild`
|
@jacoblee93 - ah, I see - I think I found the upstream codegen script - it's Added a commit that adds |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing entrypoints with
esmmodules since esbuild/esm should have the same imports. This should give us the expected CI test coverage inesbuild.It seems like these were missed because in the time
esbuildwas added,esmalready had two more commits that added entrypoints.Compare to
esm:https://github.com/hwchase17/langchainjs/blob/main/test-exports-esm/src/entrypoints.js
Test plan: