-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix redis chat message history message hydration #1374
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think dynamoDB also needs fixed!
@@ -57,19 +56,7 @@ export class RedisChatMessageHistory extends BaseListChatMessageHistory { | |||
const orderedMessages = rawStoredMessages | |||
.reverse() | |||
.map((message) => JSON.parse(message)); | |||
const previousMessages = orderedMessages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah so it was being assigned empty values before going to the mapStoredMessagesToChatMessages
:( thanks for catching
@@ -15,7 +15,13 @@ afterAll(async () => { | |||
await client.disconnect(); | |||
}); | |||
|
|||
test.skip("Test Redis history store", async () => { | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helpful comment. Thanks!
@vowelparrot no I tested dynamo and it seems fine, because it has its own custom format for saving (not ideal) |
Thanks for fixing this |
Closes #1339