Fix redis chat message history message hydration #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vowelparrot
reviewed
May 23, 2023
| @@ -57,19 +56,7 @@ export class RedisChatMessageHistory extends BaseListChatMessageHistory { | |||
| const orderedMessages = rawStoredMessages | |||
| .reverse() | |||
| .map((message) => JSON.parse(message)); | |||
| const previousMessages = orderedMessages | |||
There was a problem hiding this comment.
Ah so it was being assigned empty values before going to the mapStoredMessagesToChatMessages :( thanks for catching
vowelparrot
reviewed
May 23, 2023
| @@ -15,7 +15,13 @@ afterAll(async () => { | |||
| await client.disconnect(); | |||
| }); | |||
|
|
|||
| test.skip("Test Redis history store", async () => { | |||
| /** | |||
There was a problem hiding this comment.
Helpful comment. Thanks!
|
@vowelparrot no I tested dynamo and it seems fine, because it has its own custom format for saving (not ideal) |
vowelparrot
approved these changes
May 23, 2023
|
Thanks for fixing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1339