[patch]: Fix scripts ordering for build #4827
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:S
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -1190,7 +1190,7 @@ | |||
| "homepage": "https://github.com/langchain-ai/langchainjs/tree/main/langchain/", | |||
There was a problem hiding this comment.
Hey there! I noticed that the recent change in the package.json file has modified the "build:deps" script, removing the filter for "@langchain/core". This comment is to flag the dependency change for maintainers to review. Keep up the great work!
| @@ -15,7 +15,7 @@ | |||
| "homepage": "https://github.com/langchain-ai/langchainjs/tree/main/libs/langchain-google-gauth/", | |||
There was a problem hiding this comment.
Hey there! 👋 I noticed a change in the "build:deps" script in the package.json file, specifically the removal of the filter for "@langchain/core". This seems to indicate a modification in the project's dependencies, so I'm flagging this for your review. It looks like a change in the peer/dev/hard dependencies. Keep up the great work! 🚀
| @@ -15,7 +15,7 @@ | |||
| "homepage": "https://github.com/langchain-ai/langchainjs/tree/main/libs/langchain-google-webauth/", | |||
There was a problem hiding this comment.
Hey there! I noticed a change in the "build:deps" script in the package.json file, specifically the removal of the filter for "@langchain/core". This seems to be a change in the hard dependencies of the project. I'm flagging this for your review. Keep up the great work!
| @@ -14,8 +14,8 @@ | |||
| }, | |||
There was a problem hiding this comment.
Hey there! 👋 I noticed that this PR changes the dependencies in the package.json file, specifically the "build" and "build:deps" scripts. It looks like it's modifying the dev dependencies. I'm flagging this for your review. Keep up the great work!
If we run
yarn cleanfirst it'll try to use a script from@langchain/scriptswhich may not be built yet, thus causing an error. However, by runningyarn build:depsfirst, we will always build the scripts package preventing this error.Also, we don't need to explicitly build core because every package depends on core.