Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts[patch]: Fix check broken links script bug #5307

Merged
merged 3 commits into from
May 7, 2024

Conversation

JuHyung-Son
Copy link
Contributor

current check broken links script actually not working.
below code always executed and returned. so even if it has result.failedUrls, it never pushed

if (typeof result.linksChecked === "number") {
        return acc + result.linksChecked;
      }

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 7, 2024
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 9:07pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 7, 2024 9:07pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label May 7, 2024
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch! Thanks for pushing up a fix!

I also pushed up a commit fixing the eslint error

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label May 7, 2024
@bracesproul bracesproul changed the title fix bug scripts[patch]: Fix check broken links script bug May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants