Add MetalRetriever #613
Merged
Add MetalRetriever #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
softboyjimbo
reviewed
Apr 5, 2023
|
|
||
| const items = ("data" in res ? res.data : res) as ResponseItem[]; | ||
| return items.map( | ||
| ({ text, metadata }) => |
There was a problem hiding this comment.
we also return a dist which shows the similarity distance when running a search with a text query. Perhaps we should include this in the metadata of Document below?
softboyjimbo
approved these changes
Apr 5, 2023
|
One minor comment but this is great! Thanks @nfcampos |
nfcampos
force-pushed
the
nc/metal-retriever
branch
from
a0c3211
to
6c4eb97
Compare
nfcampos
force-pushed
the
nc/metal-retriever
branch
from
d0ff0aa
to
e8f776b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.