Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: name used for tracing should take into account APIRouter path #476

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

eyurtsev
Copy link
Collaborator

If there is a router at path /foo, and a runnable is added to that router at
path /bar, the name of the runnable should be /foo/bar for logging purposes.

@cla-bot cla-bot bot added the cla-signed label Feb 22, 2024
@eyurtsev eyurtsev changed the title Name used for tracing should take into account APIRouter path patch: name used for tracing should take into account APIRouter path Feb 22, 2024
@eyurtsev eyurtsev merged commit e1cec83 into main Feb 22, 2024
11 checks passed
@eyurtsev eyurtsev deleted the eugene/check_runnable_name branch February 22, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant