Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

langchain4j/memory.chat test coverage. #580

Merged
merged 1 commit into from
Feb 8, 2024
Merged

langchain4j/memory.chat test coverage. #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 48 additions & 2 deletions langchain4j/src/test/java/dev/langchain4j/memory/chat/MessageWindowChatMemoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,60 @@
import dev.langchain4j.data.message.SystemMessage;
import dev.langchain4j.data.message.UserMessage;
import dev.langchain4j.memory.ChatMemory;
import org.assertj.core.api.WithAssertions;
import org.junit.jupiter.api.Test;

import static dev.langchain4j.data.message.AiMessage.aiMessage;
import static dev.langchain4j.data.message.SystemMessage.systemMessage;
import static dev.langchain4j.data.message.UserMessage.userMessage;
import static org.assertj.core.api.Assertions.assertThat;

class MessageWindowChatMemoryTest {
class MessageWindowChatMemoryTest implements WithAssertions {
@Test
void test_id() {
{
ChatMemory chatMemory = MessageWindowChatMemory.builder()
.maxMessages(1)
.build();
assertThat(chatMemory.id()).isEqualTo("default");
}
{
ChatMemory chatMemory = MessageWindowChatMemory.builder()
.id("abc")
.maxMessages(1)
.build();
assertThat(chatMemory.id()).isEqualTo("abc");
}
}

@Test
void test_store_and_clear() {
ChatMemory chatMemory = MessageWindowChatMemory.builder()
.maxMessages(2)
.build();

chatMemory.add(userMessage("hello"));
chatMemory.add(userMessage("world"));

assertThat(chatMemory.messages())
.containsExactly(
userMessage("hello"),
userMessage("world")
);

chatMemory.add(userMessage("banana"));

assertThat(chatMemory.messages())
.containsExactly(
userMessage("world"),
userMessage("banana")
);

chatMemory.clear();
// idempotent
chatMemory.clear();

assertThat(chatMemory.messages()).isEmpty();
}

@Test
void should_keep_specified_number_of_messages_in_chat_memory() {
Expand Down
62 changes: 60 additions & 2 deletions langchain4j/src/test/java/dev/langchain4j/memory/chat/TokenWindowChatMemoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,76 @@
package dev.langchain4j.memory.chat;

import dev.langchain4j.data.message.AiMessage;
import dev.langchain4j.data.message.ChatMessage;
import dev.langchain4j.data.message.SystemMessage;
import dev.langchain4j.data.message.UserMessage;
import dev.langchain4j.memory.ChatMemory;
import dev.langchain4j.model.openai.OpenAiTokenizer;
import org.assertj.core.api.WithAssertions;
import org.junit.jupiter.api.Test;

import java.util.ArrayList;

import static dev.langchain4j.data.message.SystemMessage.systemMessage;
import static dev.langchain4j.data.message.UserMessage.userMessage;
import static dev.langchain4j.internal.TestUtils.*;
import static dev.langchain4j.model.openai.OpenAiModelName.GPT_3_5_TURBO;
import static org.assertj.core.api.Assertions.assertThat;
import static java.util.Collections.singletonList;

class TokenWindowChatMemoryTest implements WithAssertions {
@Test
void test_id() {
OpenAiTokenizer tokenizer = new OpenAiTokenizer(GPT_3_5_TURBO);
{
ChatMemory chatMemory = TokenWindowChatMemory.builder()
.maxTokens(2, tokenizer)
.build();
assertThat(chatMemory.id()).isEqualTo("default");
}
{
ChatMemory chatMemory = TokenWindowChatMemory.builder()
.id("abc")
.maxTokens(2, tokenizer)
.build();
assertThat(chatMemory.id()).isEqualTo("abc");
}
}

@Test
void test_store_and_clear() {
OpenAiTokenizer tokenizer = new OpenAiTokenizer(GPT_3_5_TURBO);

ChatMessage m1 = userMessage("hello");
ChatMessage m2 = userMessage("world");
ChatMessage m3 = userMessage("banana");

class TokenWindowChatMemoryTest {
int m1tokens = tokenizer.estimateTokenCountInMessage(m1);
int m2tokens = tokenizer.estimateTokenCountInMessage(m2);

int overhead = tokenizer.estimateTokenCountInMessages(new ArrayList<>());
assertThat(tokenizer.estimateTokenCountInMessages(singletonList(m1))).isEqualTo(m1tokens + 3);

ChatMemory chatMemory = TokenWindowChatMemory.builder()
.maxTokens(overhead + m1tokens + m2tokens, tokenizer)
.build();

chatMemory.add(m1);
chatMemory.add(m2);

assertThat(chatMemory.messages())
.containsExactly(m1, m2);

chatMemory.add(m3);

assertThat(chatMemory.messages())
.containsExactly(m2, m3);

chatMemory.clear();
// idempotent
chatMemory.clear();

assertThat(chatMemory.messages()).isEmpty();
}

@Test
void should_keep_specified_number_of_tokens_in_chat_memory() {
Expand Down
Loading