-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add correctly switch case to components on sidebar #2802
Conversation
…header-end-division class 🔧 (sidebarComponent/index.tsx): Ensure correct import of cn function from utils/utils file 💡 (sidebarComponent/index.tsx): Refactor sidebarContent logic to cover all conditions and provide a default case if necessary
…ring correct import of cn function
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 18 Jul 24 17:21 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…2802) * 📝 (headerComponent/index.tsx): Remove unnecessary width styling from header-end-division class 🔧 (sidebarComponent/index.tsx): Ensure correct import of cn function from utils/utils file 💡 (sidebarComponent/index.tsx): Refactor sidebarContent logic to cover all conditions and provide a default case if necessary * 📝 (sidebarComponent/index.tsx): remove unnecessary comment about ensuring correct import of cn function (cherry picked from commit 910b997)
This pull request addresses a type error in the component, stemming from poorly organized switch cases.
📝 (headerComponent/index.tsx): Remove unnecessary width styling from header-end-division class
🔧 (sidebarComponent/index.tsx): Ensure correct import of cn function from utils/utils file
💡 (sidebarComponent/index.tsx): Refactor sidebarContent logic to cover all conditions and provide a default case if necessary