fix: astra-assistants types #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request is invalid. Reason
Last Modified at 22 Jul 24 20:35 UTC |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
github-actions
bot
added
bug
dosubot
bot
added
size:XL
github-actions
bot
added
bug
anovazzi1
requested changes
Jul 23, 2024
src/backend/base/langflow/components/astra_assistants/list_assistants.py
Show resolved
Hide resolved
Adjust the styling of the TextAreaComponent in the edit node table to fix the positioning of the side-bar button. The right margin of the button was changed from 5.2rem to 4.2rem to align it correctly with the text area. This change improves the visual consistency of the edit node table.
The password visibility toggle in the TextAreaComponent was not working correctly. This commit fixes the issue by updating the condition for displaying the password icon.
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 30, 2024
* merge * [autofix.ci] apply automated fixes * support for MultilineSecretInput * add support for MultilineSecretInput * [autofix.ci] apply automated fixes * ruff * align eye-icon * tweaks and modal * [autofix.ci] apply automated fixes * textare edit modal hidden text plus eye icon * fix pydantic serialization warning * [autofix.ci] apply automated fixes * chore: Add password visibility toggle to text area components * [autofix.ci] apply automated fixes * fix list assistants * fix: remove extraneous property from is-unicode-supported dependency * fix: update TextAreaComponent styling for edit node table Adjust the styling of the TextAreaComponent in the edit node table to fix the positioning of the side-bar button. The right margin of the button was changed from 5.2rem to 4.2rem to align it correctly with the text area. This change improves the visual consistency of the edit node table. * fix modal not sync with outside state * add comment for future devs --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: anovazzi1 <otavio2204@gmail.com> (cherry picked from commit cffed2c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use Components with inputs and outputs for compatibility with Text Output and Chat Output components.
Apologies this didn't make it into the last PR.
I also add support for MultilineSecretInput for the dotenv component.