Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: python code with null and undefined #2932

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix: python code with null and undefined #2932

merged 1 commit into from
Jul 24, 2024

Conversation

lucaseduoli
Copy link
Collaborator

  • added regex to change null and undefined to None

@lucaseduoli lucaseduoli linked an issue Jul 24, 2024 that may be closed by this pull request
Null Value in Tweaks Dictionary for Python Code #2615
Closed
@lucaseduoli lucaseduoli self-assigned this Jul 24, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 24, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) July 24, 2024 21:07
@dosubot dosubot bot added bug Something isn't working python Pull requests that update Python code labels Jul 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored ✅ ❌
Pull request is made by a whitelisted user and should be ignored ❌ ❌
Pull request is submitted by a bot and should be ignored ✅ ❌
Pull request is submitted by administrators and should be ignored ❌ ❌

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages ❌ ✅
Pull request does not introduce too many changes ❌ ✅
Pull request has a valid title ✅ ✅
Pull request has mentioned issues ❌ ✅
Pull request has valid branch name ❌ ✅
Pull request should have a non-empty body ✅ ✅

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 24 Jul 24 21:07 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 24, 2024
anovazzi1
anovazzi1 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 24, 2024
@lucaseduoli lucaseduoli merged commit 00df8f8 into main Jul 24, 2024
11 of 12 checks passed
@lucaseduoli lucaseduoli deleted the 2615-null-value-in-tweaks-dictionary-for-python-code branch July 24, 2024 21:09
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
@lucaseduoli @nicoloboschi
fix: python code with null and undefined (langflow-ai#2932)
2f47e04 
Updated pythonCode to include None as replacement to null and undefined

(cherry picked from commit 00df8f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anovazzi1 anovazzi1 anovazzi1 approved these changes

Assignees

@lucaseduoli lucaseduoli

Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null Value in Tweaks Dictionary for Python Code
2 participants
@lucaseduoli @anovazzi1