feat: migrate vertex_builds to sql database #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
changed the title
nicoloboschi
force-pushed
the
migrate-built-vertex
branch
from
ff42567
to
6e67953
Compare
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ogabrielluiz
requested changes
Jul 28, 2024
| sa.Column("id", sqlmodel.sql.sqltypes.GUID(), nullable=False), | ||
| sa.Column("flow_id", sqlmodel.sql.sqltypes.GUID(), nullable=False), | ||
| sa.Column("error", sqlmodel.sql.sqltypes.AutoString(), nullable=True), | ||
| sa.ForeignKeyConstraint( |
There was a problem hiding this comment.
Please put names in the constraints in case we need to update them later on.
There was a problem hiding this comment.
that's a very good idea, I did it now for the vertex_builds.
For transactions it has been already reelased so I will leave it as is :(
There was a problem hiding this comment.
Yes. We'll have to find a way to deal with this later. SQLModel 0.0.21 has cascade_delete but it would require us to update the constraints. There's also a UUID compatibility issue in it, though.
nicoloboschi
force-pushed
the
migrate-built-vertex
branch
from
6e67953
to
d3985f3
Compare
ogabrielluiz
approved these changes
Jul 29, 2024
dosubot
bot
added
size:L
nicoloboschi
added a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 30, 2024
* feat: migrate vertex_builds to sql database * [autofix.ci] apply automated fixes * name --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> (cherry picked from commit c7575b1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.