Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bedrock access with aws access key #3032

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

nicoloboschi
Copy link
Contributor

add method to use keys instead of relying only on env

@nicoloboschi nicoloboschi marked this pull request as ready for review July 29, 2024 16:14
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request python Pull requests that update Python code labels Jul 29, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 29 Jul 24 16:14 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 29, 2024
@dosubot dosubot bot added lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 29, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3032.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 29, 2024 20:25
Cristhianzl and others added 3 commits July 29, 2024 17:52
@ogabrielluiz ogabrielluiz merged commit 58b51d1 into langflow-ai:main Jul 29, 2024
51 checks passed
nicoloboschi added a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
* feat: bedrock access with aws access key

* [autofix.ci] apply automated fixes

* chore: ignore type import in AmazonBedrockEmbeddings.py and AmazonBedrockModel.py

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
(cherry picked from commit 58b51d1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants