feat: Add logging warning when MAIL_TYPE is not set #4771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
crazywoola
approved these changes
May 29, 2024
vicwang3
pushed a commit
to vicwang3/dify
that referenced
this pull request
May 30, 2024
* origin/main: (93 commits) chore: node help link (langgenius#4795) Add SearchApi tools (langgenius#4648) chore: improve node user experience (langgenius#4792) fix: in tool and http node of iteration can not show item var correctly (langgenius#4791) feat: Add logging warning when MAIL_TYPE is not set (langgenius#4771) fix organize agent's history messages without recalculating tokens (langgenius#4324) feat: support define tags in tool yaml (langgenius#4763) feat: update ernie model (langgenius#4756) fix: incorrect workflow max call depth (langgenius#4759) feat: support baichuan3 turbo, baichuan3 turbo 128k, and baichuan4 (langgenius#4762) fix: confusing chart description (langgenius#4760) style: fix annotation panel display misalignment (langgenius#4750) Add WORKFLOW_CALL_MAX_DEPTH env var. (langgenius#4713) Fix/4742 ollama num gpu option not consistent with allowed values (langgenius#4751) style: the 'all' of add tool panel should contain workflow tools (langgenius#4755) fix: Corrected schema link in model_runtime's README.md (langgenius#4757) fix: optimize sticky header styles z-index in tools - ProviderList component (langgenius#4746) fix: workflow run sequence number slow sql (langgenius#4737) Show tool i18n name on chat pannel (langgenius#4724) fix: Correct context size for banchuan2-53b and banchuan2-turbo (langgenius#4721) ...
Sakura4036
pushed a commit
to Sakura4036/dify
that referenced
this pull request
Jun 4, 2024
dengpeng
pushed a commit
to dengpeng/dify
that referenced
this pull request
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue where emails were not sent at all because the mail_type setting was forgotten during email configuration. I believe adding logs would have made it easier to notice this issue. Therefore, I added logging. This PR aims to improve the developer experience.
Type of Change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsoptionalI have made corresponding changes to the documentationoptionalI have added tests that prove my fix is effective or that my feature worksoptionalNew and existing unit tests pass locally with my changes