-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix organize agent's history messages without recalculating tokens #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
🐞 bug
Something isn't working
🤖 feat:agent
Agent related topics
labels
May 12, 2024
Yeuoly
reviewed
May 13, 2024
@Yeuoly The code is updated, please have a review. |
Yeuoly
requested changes
May 24, 2024
Yeuoly
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contributions! |
vicwang3
pushed a commit
to vicwang3/dify
that referenced
this pull request
May 30, 2024
* origin/main: (93 commits) chore: node help link (langgenius#4795) Add SearchApi tools (langgenius#4648) chore: improve node user experience (langgenius#4792) fix: in tool and http node of iteration can not show item var correctly (langgenius#4791) feat: Add logging warning when MAIL_TYPE is not set (langgenius#4771) fix organize agent's history messages without recalculating tokens (langgenius#4324) feat: support define tags in tool yaml (langgenius#4763) feat: update ernie model (langgenius#4756) fix: incorrect workflow max call depth (langgenius#4759) feat: support baichuan3 turbo, baichuan3 turbo 128k, and baichuan4 (langgenius#4762) fix: confusing chart description (langgenius#4760) style: fix annotation panel display misalignment (langgenius#4750) Add WORKFLOW_CALL_MAX_DEPTH env var. (langgenius#4713) Fix/4742 ollama num gpu option not consistent with allowed values (langgenius#4751) style: the 'all' of add tool panel should contain workflow tools (langgenius#4755) fix: Corrected schema link in model_runtime's README.md (langgenius#4757) fix: optimize sticky header styles z-index in tools - ProviderList component (langgenius#4746) fix: workflow run sequence number slow sql (langgenius#4737) Show tool i18n name on chat pannel (langgenius#4724) fix: Correct context size for banchuan2-53b and banchuan2-turbo (langgenius#4721) ...
Sakura4036
pushed a commit
to Sakura4036/dify
that referenced
this pull request
Jun 4, 2024
…anggenius#4324) Co-authored-by: chenyongzhao <chenyz@mama.cn>
dengpeng
pushed a commit
to dengpeng/dify
that referenced
this pull request
Jun 16, 2024
…anggenius#4324) Co-authored-by: chenyongzhao <chenyz@mama.cn>
HuberyHuV1
pushed a commit
to HuberyHuV1/dify
that referenced
this pull request
Jul 22, 2024
…anggenius#4324) Co-authored-by: chenyongzhao <chenyz@mama.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐞 bug
Something isn't working
🤖 feat:agent
Agent related topics
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #2932
Add token recalculation when organize agent's history messages.
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist: