Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'rulesFile' option to config properties #281

Merged
merged 1 commit into from
Jun 30, 2015

Conversation

tingley
Copy link
Contributor

@tingley tingley commented Jun 26, 2015

First attempt at a fix for issue #280.

This adds a new option, rulesFile, to the server configuration file specified with --config. The rulesFile option points to the location of a .languagetool.cfg-style rules file.

This is a little odd (the config file now points to another config file), but my thinking was that it was better to keep the server options consolidated in the --config file, rather than adding a new top-level switch. I am also allowing the rulesFile param to point to an arbitrary file location, since that's more convenient for server deployment scenarios where we don't want to depend on things like the location of the home directory of the "user" running the service.

I'm happy to rework any portion of this if you'd like it to work a different way.

    This allows server mode to point to a GUI rules configuration to
    load as a server configuration.
@danielnaber
Copy link
Member

Thanks, looks good. I'll merge in a few days once we're out of feature freeze for LT 3.0.

danielnaber added a commit that referenced this pull request Jun 30, 2015
Add 'rulesFile' option to config properties
@danielnaber danielnaber merged commit 1690f91 into languagetool-org:master Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants