Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogindSessionsIdle check should ignore IdleHint of "greeter" sessions (display managers e.g. lightdm) #366

Closed
APO67 opened this issue May 7, 2023 · 3 comments · Fixed by #407
Closed

LogindSessionsIdle check should ignore IdleHint of "greeter" sessions (display managers e.g. lightdm) #366

APO67 opened this issue May 7, 2023 · 3 comments · Fixed by #407
Labels
released

Comments

@APO67
Copy link

APO67 commented May 7, 2023

The LogindSessionsIdle prevents system to suspend if there is a greeter (e.g. lightdm) running.
By adding an option to ignore some sessions based on session Class the LogindSessionsIdle check could be improved.
For normal sessions the Class is "user" and for Greeter sessions the Class is "greeter".
@languitar
Copy link
Owner

Good catch. I wasn't aware of the fact that greeters also have a constantly running session. Can you provide a patch for this feature?

@APO67
Copy link
Author

APO67 commented May 8, 2023

It would take while until I could provide a patch. Therefore I think is is match more efficient if you add this feature.

languitar added a commit that referenced this issue Aug 13, 2023
@languitar
feat(logind)!: configure which session classes to process
986e558 
logind sessions have different classes. So far, all classes of logind
sessions were taken into account. However, this might include greeter
sessions by tools such as lightdm. With this commit, a new config
option for the LogindSessionIdle check allows configuring which classes
of sessions to look at. The default value restricts processing to users
sessions as a sensible default.

BREAKING CHANGE: LogindSessionIdle now only processes sessions of type
    "user" by default. Use the new configuration option classes to also
    include other types in case you need to include them in the checks.
Fixes: #366
@languitar languitar mentioned this issue Aug 13, 2023
Merged
github-actions bot pushed a commit that referenced this issue Aug 13, 2023
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
ac8e095 
# [5.0.0](v4.3.3...v5.0.0) (2023-08-13)

* feat(logind)!: configure which session classes to process ([986e558](986e558)), closes [#366](#366)

### BREAKING CHANGES

* LogindSessionIdle now only processes sessions of type
    "user" by default. Use the new configuration option classes to also
    include other types in case you need to include them in the checks.
@github-actions
Copy link

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(logind)!: configure which session classes to process languitar/autosuspend
2 participants
@languitar @APO67