Update documentation #461
Update documentation #461
Conversation
missed it in the earlier commit because it was defined in core/constraint.jl but not core/constraint_template.jl
PowerModels.ismultinetwork is defined on PowerModels and not data dictionaries
it is too verbose
Codecov Report
@@ Coverage Diff @@
## master #461 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 35 35
Lines 5007 5007
=======================================
Hits 4720 4720
Misses 287 287
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #461 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 35 35
Lines 5007 5007
=======================================
Hits 4720 4720
Misses 287 287
Continue to review full report at Codecov.
|
|
LGTM, any objections @kaarthiksundar, @pseudocubic? |
|
This looks great. Thanks @yeesian. I have no issues with the PR |
| "minor":<int>, | ||
| "patch":<int>, | ||
| ... | ||
| }, |
There was a problem hiding this comment.
This doesn't seem necessary, since we can just use a single string to represent a version. Is this to support some change I'm not aware of having been discussed?
There was a problem hiding this comment.
I was going by the output from
using PowerModels
network_data = PowerModels.parse_file("matpower/case3.m")
JSON.json(network_data)Julia's version strings gets turned into such dictionaries in JSON.jl
If a string is preferred, then that line should be modified accordingly.
There was a problem hiding this comment.
Ah, I wasn't aware that it did this. I will make a new Issue to fix it, and will revert the documentation when it gets fixed.
As promised in #169