Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcontrols #49

Merged
merged 2 commits into from
May 31, 2018
Merged

Xcontrols #49

merged 2 commits into from
May 31, 2018

Conversation

cnegre
Copy link
Collaborator

@cnegre cnegre commented May 31, 2018

Changed xControl= to XCONTROL= keywords in the parser for consistency.

@cnegre cnegre requested a review from nfaguirrec May 31, 2018 03:32
@codecov
Copy link

codecov bot commented May 31, 2018

Codecov Report

Merging #49 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   43.24%   43.22%   -0.02%     
==========================================
  Files         193      193              
  Lines       14808    14810       +2     
==========================================
- Hits         6404     6402       -2     
- Misses       8404     8408       +4
Impacted Files Coverage Δ
src/latteparser_latte_mod.f90 92.66% <50%> (-0.8%) ⬇️
src/kfcoulnono.f90 51.61% <0%> (-0.93%) ⬇️
src/kbldnewh.f90 42.57% <0%> (-0.67%) ⬇️
src/kgradH.f90 53.02% <0%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7082345...0b99f22. Read the comment docs.

Copy link
Collaborator

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you might want to reset your authorship on the change to get credit for it.

git commit --amend --author "Christian Negre <cnegre@lanl.gov>" HEAD

Should do it. But that doesn't fix the commit before that ☹️ ....

@nicolasbock
Copy link
Collaborator

I reset the authors in your commits.

@junghans
Copy link
Member

E.g. for https://www.openhub.net/p/LANL_LATTE

@cnegre cnegre merged commit 9c276c7 into master May 31, 2018
@cnegre cnegre deleted the xcontrols branch June 6, 2018 21:42
cnegre added a commit that referenced this pull request Jul 3, 2018
* Changed xControl= to XCONTROL=

* Changed xControl= to XCONTROL=
nfaguirrec pushed a commit that referenced this pull request Jul 4, 2018
* Changed xControl= to XCONTROL=

* Changed xControl= to XCONTROL=
nfaguirrec pushed a commit that referenced this pull request Jul 4, 2018
* Changed xControl= to XCONTROL=

* Changed xControl= to XCONTROL=
nfaguirrec pushed a commit that referenced this pull request Jul 4, 2018
* Changed xControl= to XCONTROL=

* Changed xControl= to XCONTROL=
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants