-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add type stubs #37
add type stubs #37
Conversation
Nice! At first glance, this is pretty much what I was hoping for with no duplication. |
Do you know how we can test this? It'd be great to incorporate something into the current unit-testing framework. |
I have the following test in my projects: |
That's great. Thanks! |
@gfairchild are there any plans to geht this merged? Otherwise I will close the PR. |
I apologize. I'd love to spend more time reviewing this, but I just haven't had time. I don't really use this code base much anymore. I'd prefer to leave the PR open instead of close. |
Unless I have a special interest in a PR, I close them at some point around the 1 year mark. However feel free to merge this into a branch and create your own PR you can look into if you ever find the time. |
I'm going to go ahead and merge. Thank you, @maxbachmann, for your contribution, and I apologize for how long it took me to act on this. |
@gfairchild this is how I implement installation + type stubs in my projects. This avoids the duplication from #34.
The only duplicated file is the actual type hint, which can't be avoided when working with c extensions.