Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysterious and intermittent test failures #212

Closed
Michael-T-McCann opened this issue Feb 7, 2022 · 4 comments · Fixed by #230
Closed

Mysterious and intermittent test failures #212

Michael-T-McCann opened this issue Feb 7, 2022 · 4 comments · Fixed by #230
Assignees
Labels
tests Pertaining to SCICO tests

Comments

@Michael-T-McCann
Copy link
Contributor

We have had occasional test failures: https://github.com/lanl/scico/runs/5062268572?check_suite_focus=true, https://github.com/lanl/scico/runs/5078490742?check_suite_focus=true

These involve scico/test/test_functional.py, and specifically scico/test/test_functional.py::TestNormProx::test_prox[float32-0.01-NuclearNorm] and scico/test/linop/test_optics.py::TestPropagator::test_prop_adjoint[FraunhoferPropagator-1]`. Search the very long stack trace for "typeerror:" to see what I think is the actual error.

@Michael-T-McCann Michael-T-McCann self-assigned this Feb 7, 2022
@Michael-T-McCann
Copy link
Contributor Author

Michael-T-McCann commented Feb 7, 2022

Minimal code to reproduce. In the file temp_svd.py, put

import jax
import jax.numpy as jnp


def test():
    key = jax.random.PRNGKey(3)
    v = jax.random.normal(shape=(32, 1), key=key)

    svdU, svdS, svdV = jnp.linalg.svd(v, full_matrices=False)
    x = svdU @ jnp.diag(svdS) @ svdV
    sigma = jnp.linalg.svd(x, compute_uv=False)
    assert len(sigma) == 1

test()

then try

while python temp_svd.py
do
:
done

and wait. On my machine, you get a failure eventually, say within 100 iterations.

@Michael-T-McCann
Copy link
Contributor Author

I have opened an issue with jax team on this: google/jax#9483

@bwohlberg bwohlberg added the tests Pertaining to SCICO tests label Feb 8, 2022
@Michael-T-McCann
Copy link
Contributor Author

When/if this gets fixed on jax's side, let's revisit (probably roll back) #214.

@Michael-T-McCann Michael-T-McCann removed their assignment Feb 8, 2022
@Michael-T-McCann Michael-T-McCann self-assigned this Feb 23, 2022
@Michael-T-McCann
Copy link
Contributor Author

Revert the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pertaining to SCICO tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants