Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change svd call to avoid compute_uv=False #214

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Conversation

Michael-T-McCann
Copy link
Contributor

Intended as a temporary workaround for the intermittent test failures discussed in #212 .

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #214 (2fcfd85) into main (2b7a693) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files          48       48           
  Lines        3358     3359    +1     
=======================================
+ Hits         3100     3101    +1     
  Misses        258      258           
Flag Coverage Δ
unittests 92.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/functional/_norm.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b7a693...2fcfd85. Read the comment docs.

Copy link
Collaborator

@bwohlberg bwohlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's leave #212 open until the jax bug is resolved as a reminder of the need to revert this change when possible.

@bwohlberg bwohlberg added bug Something isn't working tests Pertaining to SCICO tests labels Feb 8, 2022
@Michael-T-McCann Michael-T-McCann merged commit 9b09bcf into main Feb 8, 2022
@Michael-T-McCann Michael-T-McCann deleted the mike/svd branch February 8, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Pertaining to SCICO tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants