Revert SVD workaround #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
==========================================
+ Coverage 92.50% 92.52% +0.02%
==========================================
Files 49 49
Lines 3455 3452 -3
==========================================
- Hits 3196 3194 -2
+ Misses 259 258 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bwohlberg
reviewed
Feb 23, 2022
scico/functional/_norm.py
Outdated
| if isinstance(s, tuple): | ||
| s = s[1] | ||
| return snp.sum(s) | ||
| return snp.sum(snp.linalg.svd(x, compute_uv=False)) |
There was a problem hiding this comment.
Perhaps safer to leave in the full_matrices=False?
Michael-T-McCann
force-pushed
the
mike/svd_revert
branch
from
9d75aaa
to
4603e31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #212