Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to examples scripts #137

Merged
merged 12 commits into from
Dec 17, 2021
Merged

Changes to examples scripts #137

merged 12 commits into from
Dec 17, 2021

Conversation

bwohlberg
Copy link
Collaborator

@bwohlberg bwohlberg commented Dec 16, 2021

  • Improve notebook build script
    • don't terminate entire run on single notebook execution failure
    • clean up workers after keyboard interrupt
  • Minor edits to example script docstrings

@bwohlberg bwohlberg added the examples Pertaining to SCICO examples label Dec 16, 2021
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #137 (d525a83) into main (1ecc960) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          47       47           
  Lines        3206     3206           
=======================================
  Hits         2947     2947           
  Misses        259      259           
Flag Coverage Δ
unittests 91.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ecc960...d525a83. Read the comment docs.

Copy link
Contributor

@FernandoDavis FernandoDavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine to me! There's one nitpick but that shouldn't hold back the PR and can be discussed on Monday with the other pending edit.

examples/makenotebooks.py Show resolved Hide resolved
@bwohlberg bwohlberg merged commit fe2a50e into main Dec 17, 2021
@bwohlberg bwohlberg deleted the brendt/examples branch December 17, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Pertaining to SCICO examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants