Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous changes #143

Merged
merged 22 commits into from
Dec 20, 2021
Merged

Miscellaneous changes #143

merged 22 commits into from
Dec 20, 2021

Conversation

bwohlberg
Copy link
Collaborator

  • Modify setup.py to improve consistency in dependency specification
  • Add note to docs on pinning black version in conda
  • Implement more compact iteration stats initialization in optimizer classes (except PGM)
  • Additional iteration stats columns for iterative ADMM subproblem solvers
  • More robust implementation of IterationStats.__init__
  • Abbreviate ADMM primal residual column name in iteration stats
  • Suppress annoying pytest DeprecationWarning regarding imp in compat

@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #143 (38a1781) into main (f899f3a) will increase coverage by 0.14%.
The diff coverage is 96.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   91.92%   92.07%   +0.14%     
==========================================
  Files          47       47              
  Lines        3209     3231      +22     
==========================================
+ Hits         2950     2975      +25     
+ Misses        259      256       -3     
Flag Coverage Δ
unittests 92.07% <96.22%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/__init__.py 87.50% <ø> (ø)
scico/optimize/pgm.py 94.81% <0.00%> (ø)
scico/diagnostics.py 88.23% <92.85%> (+0.35%) ⬆️
scico/optimize/_ladmm.py 98.86% <100.00%> (+1.21%) ⬆️
scico/optimize/_primaldual.py 100.00% <100.00%> (+1.31%) ⬆️
scico/optimize/admm.py 96.09% <100.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f899f3a...38a1781. Read the comment docs.

@bwohlberg bwohlberg linked an issue Dec 19, 2021 that may be closed by this pull request
pytest.ini Show resolved Hide resolved
scico/optimize/admm.py Show resolved Hide resolved
scico/optimize/admm.py Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
scico/optimize/pgm.py Show resolved Hide resolved
@bwohlberg bwohlberg merged commit 3dfa33d into main Dec 20, 2021
@bwohlberg bwohlberg deleted the brendt/new-misc branch December 20, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jax and jaxlib version restrictions in scico/__init__.py
4 participants