Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous changes (to be closed) #142

Closed
wants to merge 47 commits into from
Closed

Miscellaneous changes (to be closed) #142

wants to merge 47 commits into from

Conversation

bwohlberg
Copy link
Collaborator

@bwohlberg bwohlberg commented Dec 18, 2021

See #143: rebase of this branch to remove already-merged commit. This PR will be closed once #143 is merged.

  • Modify setup.py to improve consistency in dependency specification
  • Add note to docs on pinning black version in conda
  • Implement more compact iteration stats initialization in optimizer classes (except PGM)
  • Additional iteration stats columns for iterative ADMM subproblem solvers
  • More robust implementation of IterationStats.__init__
  • Abbreviate ADMM primal residual column name in iteration stats
  • Suppress annoying DeprecationWarning regarding imp in compat

@bwohlberg bwohlberg added the enhancement New feature or request label Dec 18, 2021
@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #142 (b0362ca) into main (3dfa33d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          47       47           
  Lines        3231     3231           
=======================================
  Hits         2975     2975           
  Misses        256      256           
Flag Coverage Δ
unittests 92.07% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dfa33d...b0362ca. Read the comment docs.

@bwohlberg bwohlberg marked this pull request as ready for review December 19, 2021 02:09
@bwohlberg bwohlberg marked this pull request as draft December 19, 2021 20:20
@bwohlberg bwohlberg changed the title Miscellaneous changes Miscellaneous changes (to be closed) Dec 19, 2021
@bwohlberg
Copy link
Collaborator Author

All changes already introduced in #143.

@bwohlberg bwohlberg closed this Dec 20, 2021
@bwohlberg bwohlberg deleted the brendt/misc branch December 20, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant