Make output types jax-array #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 92.21% 92.24% +0.02%
==========================================
Files 48 48
Lines 3353 3353
==========================================
+ Hits 3092 3093 +1
+ Misses 261 260 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bwohlberg
added
the
improvement
bwohlberg
reviewed
Jan 25, 2022
scico/functional/_denoiser.py
Outdated
| @@ -110,7 +111,7 @@ def prox(self, x: JaxArray, lam: float = 1.0, **kwargs) -> JaxArray: | |||
| # undo squeezing, if neccessary | |||
| y = y.reshape(x_in_shape) | |||
|
|
|||
| return y | |||
| return jax.device_put(y) | |||
There was a problem hiding this comment.
The return type here was a numpy ndarray? I would have expected hcb.call to keep things within the jax world.
There was a problem hiding this comment.
You are right, the device_put wasn't necessary here. Fixed it.
bwohlberg
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes output types of svmbir and bm3d to be always jaxarrays. Fixes issue #93