Make SCICO compatible with jax 0.3.4 #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-T-McCann
force-pushed
the
mike/jax-v0.3.4
branch
from
eb6007e
to
9a048e0
Compare
Michael-T-McCann
force-pushed
the
mike/jax-v0.3.4
branch
from
9a048e0
to
16c58df
Compare
Codecov Report
@@ Coverage Diff @@
## main #256 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 49 49
Lines 3528 3528
=======================================
Hits 3302 3302
Misses 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failures were coming use of the deprecated
jax.ops.index, appears to be functionally equivalent toslice. So, easy to fix.Also needed to bump the tolerance on one blockarray test.