Make adjoint and gram get auto set separately #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
==========================================
+ Coverage 94.77% 94.87% +0.09%
==========================================
Files 83 83
Lines 5262 5265 +3
==========================================
+ Hits 4987 4995 +8
+ Misses 275 270 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bwohlberg
changed the title
bwohlberg
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a LinOp needed either a gram operator or an adjoint, both would be automatically generated. In particular, this meant that user-defined adjoint would be overwritten if the user did not also set the gram. This PR splits the two.
Addresses #331