Add support for 3D tomographic projection with astra #427
Conversation
Codecov Report
@@ Coverage Diff @@
## main #427 +/- ##
==========================================
- Coverage 94.82% 94.63% -0.19%
==========================================
Files 86 86
Lines 5422 5471 +49
==========================================
+ Hits 5141 5177 +36
- Misses 281 294 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Michael-T-McCann
force-pushed
the
mike/astra_3d
branch
from
88b58ca
to
b462330
Compare
examples/scripts/index.rst
Outdated
There was a problem hiding this comment.
The new example has been added to the main index file, but I don't see it in the built docs. Perhaps you still need to run makeindex.py and commit the changed secondary index files?
There was a problem hiding this comment.
I think I did this, but it's still not showing up as far as I can tell. Any suggestions?
There was a problem hiding this comment.
Perhaps a problem with the submodule commit attached to this branch. When the submodule changes in a PR, it's usually cleanest to make a corresponding branch and PR for scico-data, with the submodule here linked to the head of that branch.
There was a problem hiding this comment.
Ah, the generated notebook was blank and sphinx was smart enough to not include it. Working on a fix.
|
It would be worth adding a note on this extended capability in |
There was a problem hiding this comment.
Looks good except for the absence of the new example notebook in the docs. This appears to be because the notebook corresponding to the new example script is bad: it's just an almost-empty .ipynb structure, with no real content. Rebuilding the notebook should fix this issue, I would hope. The previous build probably failed because it was run on a host without a GPU.
Supersedes #424