Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 3D tomographic projection with astra #427
Add support for 3D tomographic projection with astra #427
Changes from 10 commits
9d598fe
4b3895e
654b10f
f58cb60
88b7122
1b27e57
cfb4a88
0237326
696ad3c
b462330
74637a0
2f6aaad
f592b24
cec0cd2
42f9e97
170ac4a
8bf2a74
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new example has been added to the main index file, but I don't see it in the built docs. Perhaps you still need to run
makeindex.py
and commit the changed secondary index files?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I did this, but it's still not showing up as far as I can tell. Any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a problem with the submodule commit attached to this branch. When the submodule changes in a PR, it's usually cleanest to make a corresponding branch and PR for
scico-data
, with the submodule here linked to the head of that branch.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the generated notebook was blank and sphinx was smart enough to not include it. Working on a fix.