Update from original #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* first pass at refactoring detrend * remove comments * fix chunking * add 3D case * add error checking; implement 2D detrend * add more 2D test cases * black * refactor xrft and update tests * fix typo in detrend test * doc updates
* phase + fftshift * phase + fftshift2 * adding cftime compatibility * adding cftime compatibility wo print * black reformatting * new pre-commit * adding test for phase preservation * adding preserve_total_phase argument * correct lag for odd number of point * rm print and renaming true_phase arg * updated correction for odd number of point * np.fft to fft * add parameterization for dask on true_phase * adding test_true_phase and updated test_true_phase_preservation * upgrade miniconda action * actually upgrade miniconda action * use other miniconda action * adding test_theoretical_matching Co-authored-by: Frederic <frederic.nouguier@ifremer.fr> Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.