-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapting lansuite to abide STRICT_TRANS_TABLES #458
base: master
Are you sure you want to change the base?
Changes from all commits
a6cec7e
2805ca0
5ac9f68
3ae7dac
c9a2af2
d95b779
a00840d
18ae9ac
0bd0307
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -116,7 +116,7 @@ | |
<type>datetime</type> | ||
<null></null> | ||
<key></key> | ||
<default>0</default> | ||
<default></default> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you elaborate a bit why removing the default is necessary here? (same question applies to the other datetime fields) |
||
<extra></extra> | ||
</field> | ||
<field> | ||
|
@@ -451,7 +451,7 @@ | |
<type>datetime</type> | ||
<null></null> | ||
<key></key> | ||
<default>0</default> | ||
<default></default> | ||
<extra></extra> | ||
</field> | ||
<field> | ||
|
@@ -1159,7 +1159,7 @@ | |
</field> | ||
<field> | ||
<name>module</name> | ||
<type>char(20)</type> | ||
<type>char(255)</type> | ||
<null></null> | ||
<key>IND</key> | ||
<default></default> | ||
|
@@ -1483,7 +1483,7 @@ | |
<type>datetime</type> | ||
<null></null> | ||
<key></key> | ||
<default>0</default> | ||
<default></default> | ||
<extra></extra> | ||
</field> | ||
<field> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,7 +98,7 @@ | |
<type>datetime</type> | ||
<null></null> | ||
<key></key> | ||
<default></default> | ||
<default>0000-00-00 00:00:00</default> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What makes this datetime field different from the others when it comes to the default value? |
||
<extra></extra> | ||
</field> | ||
<field> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -303,7 +303,7 @@ | |
<type>datetime</type> | ||
<null></null> | ||
<key></key> | ||
<default></default> | ||
<default>0000-00-00 00:00:00</default> | ||
<extra></extra> | ||
</field> | ||
<field> | ||
|
@@ -333,7 +333,7 @@ | |
<field> | ||
<name>rules</name> | ||
<type>text</type> | ||
<null></null> | ||
<null>YES</null> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you elaborate why this is needed? |
||
<key></key> | ||
<default></default> | ||
<extra></extra> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this ever work without casting/double checks?
$default_xml
is set bygetFirstTagContent
will always return a string, even is0
is in it.Maybe it is better to run something like
$default_xml === '0'
?See
lansuite/inc/Classes/XML.php
Lines 16 to 41 in 7e16dd2