Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TravisCI: Exclude PSR1.Methods.CamelCapsMethodName.NotCamelCaps rule #461

Merged
merged 1 commit into from
Nov 27, 2020
Merged

TravisCI: Exclude PSR1.Methods.CamelCapsMethodName.NotCamelCaps rule #461

merged 1 commit into from
Nov 27, 2020

Conversation

andygrunwald
Copy link
Collaborator

@andygrunwald andygrunwald commented Nov 21, 2020 •
edited
Loading

We exclude the PSR1.Methods.CamelCapsMethodName.NotCamelCaps rule to make the build pass again.
The codebase is quite old and it might not lead to a huge benefit of
changing all the method's name to match the NotCamelCaps rule.

@andygrunwald
TravisCI: Exclude PSR1.Methods.CamelCapsMethodName.NotCamelCaps rule
451189a 
We exclude the PSR1.Methods.CamelCapsMethodName.NotCamelCaps rule to make
the build pass again.
The codebase is quite old and it might not lead to a huge benefit of
changing all the methods name to match the NotCamelCaps rule.
@andygrunwald andygrunwald merged commit 1fb733b into master Nov 27, 2020
@andygrunwald andygrunwald deleted the make-master-pass-again branch November 27, 2020 12:10
@M4LuZ
Copy link
Collaborator

M4LuZ commented Nov 28, 2020

Sorry, late to the party.
Fine by me, there is more important stuff to worry about.
(would have voted though to name branch "make-master-great-again" ;))

M4LuZ added a commit that referenced this pull request Dec 3, 2020
@M4LuZ
Raised PHP build versions to 7.2 - 7.4 and hopefully fixed issue with…
bf7ebd9 
… Travis (wrong method name applied in PR #458)

refs #455
fixes #461
@M4LuZ M4LuZ mentioned this pull request Dec 3, 2020
Merged
andygrunwald pushed a commit that referenced this pull request Dec 3, 2020
@M4LuZ @andygrunwald
Raised PHP build versions to 7.2 - 7.4 and hopefully fixed issue with…
aa7d405 
… Travis (wrong method name applied in PR #458)

refs #455
fixes #461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4LuZ M4LuZ Awaiting requested review from M4LuZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andygrunwald @M4LuZ