Update jQuery & jQuery UI versions

[M4LuZ]

What is this PR doing?

Updates currently embedded versions of jQuery and jQuery UI.
Functionality was validated (to best knowledge) but it can't hurt to have a few others try this also

Which issue(s) this PR fixes:

Fixes #841

Checklist

• CHANGELOG.md entry
• Documentation update no change in functionality / dependency

[andygrunwald]

Thats a good one.

Do we know in which places we use JQuery? This would help me to test the change.

[M4LuZ]

Thats a good one.

Do we know in which places we use JQuery? This would help me to test the change.

I've identified occurrences by searching the code for $( as to my knowledge that is the sequence to invoke JQuery-specific functionality.
Occurrences can be found in #841, but have it copied here for convenience:

• Confirm correct functionality
  • inc/Classes/Display.php::EndTabs() - Confirmed OK (Clicked through tabs in Module configs)
  • broken anyways due to API changes -> modules/install/translation.php::case 20 fix defunct code as google translate API is broken #842
  • appears to be unused code for JS-Pagination -> modules/mastersearch/templates/result_case.htm implement JS pagination #843
  • modules/shoutbox/templates/box-template.htm::success(), validate(), refresh(), removeOld() - Confirmed OK
  • scripts.js::ActivateTab() - Confirmed OK (Clicked through tabs in Module configs)

[sonarcloud]

Quality Gate failed

Failed conditions

9 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[M4LuZ]

nudging @lansuite/lansuite-developers to have a look, as this may have a larger impact on functionality than currently known

[M4LuZ]

@lansuite/lansuite-developers Given the lack of negative/any feedback I guess we're fine to merge here?
@andygrunwald: how should we proceed in regards to file minifation?

Ship the non-minified version
Ship the minified version only
Ship both and include based on debugging switch
build the minified version ourselves with uglify-js (giving us the original, the minified version and the mapping file)

[M4LuZ]

@lansuite/lansuite-developers Given the lack of negative/any feedback I guess we're fine to merge here? @andygrunwald: how should we proceed in regards to file minifation?

Ship the non-minified version
Ship the minified version only
Ship both and include based on debugging switch
build the minified version ourselves with uglify-js (giving us the original, the minified version and the mapping file)

Reminder to all ;)

[andygrunwald]

@M4LuZ I tested the PR - Looks good!

About which version we do ship:
In my opinion, should only ship the minified version only (applies to CSS as well).
It is very rare that we discover a bug in jQuery - Hence, debugging might be only in our code required. I don't see a point in shipping the non-minified version at all.
For development, we use the documentation of jQuery.

This would mean deleting all non-minified versions.
Additionally: I don't see a need to ship the LICENSE file, as the license link is also available in the header of the minified version.

After this, I am good with merging this.

[M4LuZ]

Unneeded files removed as discussed

Additionally: I don't see a need to ship the LICENSE file, as the license link is also available in the header of the minified version.

As quoted above the license requirements are clear and the license text (not just a refrence) is to be included.

The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

Given the size (and the apparent lack of need to optimize space usage or amount of files as per #873) this does not really matter anyways, does it?

[andygrunwald]

Looking good.

[andygrunwald]

@M4LuZ Space is, indeed not an issue. And we should follow the license. I overlooked this part.

About ext_scripts/jquery-ui/external/jquery/jquery.js
I still would delete this file. Primarily to avoid confusion for developers on why we have two versions of jQuery and why the "external" is not used.

If you agree, I will delete ext_scripts/jquery-ui/external/jquery/jquery.js and merge it through.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[M4LuZ]

deleted & merged