Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injection of RemoteDocumentLoader #72

Closed
wants to merge 4 commits into from
Closed

Injection of RemoteDocumentLoader #72

wants to merge 4 commits into from

Conversation

zobzn
Copy link
Contributor

@zobzn zobzn commented Jul 29, 2016

No description provided.

@lanthaler
Copy link
Owner

I'll give this a look on the weekend

@@ -28,7 +28,7 @@ class FileGetContentsLoader
*
* @throws JsonLdException If loading the document failed.
*/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace the DocBlock with

/**
 * {@inheritdoc}
 */

@lanthaler
Copy link
Owner

@zobzn still interested in getting this PR merged?

@lanthaler lanthaler closed this in f10bbfe Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants