Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add command and keybinds to delete line #2071

Merged
merged 1 commit into from Jan 28, 2023
Merged

Conversation

panekj
Copy link
Collaborator

@panekj panekj commented Jan 28, 2023

  • Added an entry to CHANGELOG.md if this change could be valuable to users

Fixes #1966

@panekj panekj added A-keymap Area: default key bindings A-editor Area: editor, modal editing C-improvement Category: general improvement that is not a new feature or a bugfix C-feature Category: New feature or request and removed C-improvement Category: general improvement that is not a new feature or a bugfix labels Jan 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Merging #2071 (c8bb960) into master (0ae86e6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##           master   #2071      +/-   ##
=========================================
- Coverage    9.00%   9.00%   -0.01%     
=========================================
  Files         135     135              
  Lines       58822   58837      +15     
=========================================
+ Hits         5295    5296       +1     
- Misses      53527   53541      +14     
Impacted Files Coverage Δ
lapce-core/src/command.rs 0.00% <ø> (ø)
lapce-core/src/editor.rs 29.31% <0.00%> (-0.33%) ⬇️
lapce-data/src/keypress/keypress.rs 73.23% <0.00%> (+0.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dzhou121 dzhou121 merged commit 950b40d into master Jan 28, 2023
@dzhou121 dzhou121 deleted the feat/delete-line branch January 28, 2023 19:51
@panekj panekj added this to the Next release milestone Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area: editor, modal editing A-keymap Area: default key bindings C-feature Category: New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Delete line" command
3 participants