Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate binding for Shift-Delete #2246

Merged
merged 1 commit into from Mar 14, 2023
Merged

Conversation

lnicola
Copy link
Contributor

@lnicola lnicola commented Mar 14, 2023

  • Added an entry to CHANGELOG.md if this change could be valuable to users

#2071 added this binding, but it's redundant with the existing one (for cut). Worse, the result is that two lines are removed instead of a single one.

I think it's better to cut instead of deleting because that's what every editor I've seen does. And Cut without a selection, already cuts the whole line, as it does everywhere else.

@lnicola
Copy link
Contributor Author

lnicola commented Mar 14, 2023

CC @phw

@panekj panekj changed the title Remove broken binding for Shift-Delete Remove duplicate binding for Shift-Delete Mar 14, 2023
@panekj panekj merged commit 3c2e6e8 into lapce:master Mar 14, 2023
@panekj panekj added this to the Next release milestone Mar 14, 2023
@panekj panekj added C-bug Category: bug - something isn't working as it's supposed to A-keymap Area: default key bindings labels Mar 14, 2023
@lnicola lnicola deleted the fix-shift-del branch March 14, 2023 17:34
@phw
Copy link

phw commented Mar 14, 2023

And Cut without a selection, already cuts the whole line, as it does everywhere else.

"Cut" and "Delete lines" are not identical. "Cut" cuts the selection, whereas delete lines does delete all selected lines (also partially selected). But as the delete_line command you added handles this all is good for me, don't need a default key binding.

And the delete_line action works well for me, thanks a lot for this :) I usually have it bound to Ctrl+Shift+K .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-keymap Area: default key bindings C-bug Category: bug - something isn't working as it's supposed to
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants