Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong user recorded for activities #5

Open
jrd-lewis opened this issue May 4, 2019 · 0 comments
Open

Wrong user recorded for activities #5

jrd-lewis opened this issue May 4, 2019 · 0 comments

Comments

@jrd-lewis
Copy link

I noticed this issue in Episode 30 at the timestamp of 12:30, and checked the code from the end of the series to look ahead to see if it was resolved, but it has not been yet. This issue comes from the recordActivity method in app\RecordsActivity.php when we set the user_id field.

An example of this issue: if another project member makes a change to the project, it records the activity as being done by the project's owner instead of the project member who made the change.

A potential solution would be checking for a signed in user, and if it didn't find one (so we don't have to sign in for all the tests), then it could defer to the project owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant