Skip to content

Commit

Permalink
Fix Permission denied (#1893)
Browse files Browse the repository at this point in the history
* Revert "default user for workspace is laradock, so that owner of log file when running php artisan command doesn't change (#1875)"

This reverts commit 156d124.

* update document to inform user should add --user=laradock when exec into workspace, update sync.sh bash to exec into workspace with user laradock
  • Loading branch information
lanphan authored and bestlong committed Nov 27, 2018
1 parent 2203297 commit fa7d3c2
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion DOCUMENTATION/content/documentation/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ docker-compose ps
docker-compose exec workspace bash
```

Add `--user=laradock` (example `docker-compose exec --user=laradock workspace bash`) to have files created as your host's user.
Note: Should add `--user=laradock` (example `docker-compose exec --user=laradock workspace bash`) to have files created as your host's user to prevent issue owner of log file will be changed to root then laravel website cannot write on log file if using rotated log and new log file not existed


4 - Run anything you want :)
Expand Down
4 changes: 2 additions & 2 deletions sync.sh
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ display_options () {
print_style " install" "info"; printf "\t\t Installs docker-sync gem on the host machine.\n"
print_style " up [services]" "success"; printf "\t Starts docker-sync and runs docker compose.\n"
print_style " down" "success"; printf "\t\t\t Stops containers and docker-sync.\n"
print_style " bash" "success"; printf "\t\t\t Opens bash on the workspace.\n"
print_style " bash" "success"; printf "\t\t\t Opens bash on the workspace with user laradock.\n"
print_style " sync" "info"; printf "\t\t\t Manually triggers the synchronization of files.\n"
print_style " clean" "danger"; printf "\t\t Removes all files from docker-sync.\n"
}
Expand Down Expand Up @@ -69,7 +69,7 @@ elif [ "$1" == "down" ]; then
docker-sync stop

elif [ "$1" == "bash" ]; then
docker-compose exec workspace bash
docker-compose exec --user=laradock workspace bash

elif [ "$1" == "install" ]; then
print_style "Installing docker-sync\n" "info"
Expand Down
4 changes: 2 additions & 2 deletions workspace/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -889,12 +889,12 @@ RUN php -v | head -n 1 | grep -q "PHP ${LARADOCK_PHP_VERSION}."
#--------------------------------------------------------------------------
#

USER root

# Clean up
RUN apt-get clean && \
rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* && \
rm /var/log/lastlog /var/log/faillog

USER laradock

# Set default work directory
WORKDIR /var/www

0 comments on commit fa7d3c2

Please sign in to comment.